Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first person 3D eye-camera #5249

Merged
merged 12 commits into from
Feb 26, 2024
Merged

Add first person 3D eye-camera #5249

merged 12 commits into from
Feb 26, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 22, 2024 •
edited by github-actions bot
Loading

What

This adds a first-person mode to the eye-camera, selectable in the selection panel.

first-person-camera.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 📺 re_viewer affects re_viewer itself include in changelog labels Feb 22, 2024
@emilk emilk marked this pull request as ready for review February 22, 2024 09:14
@Wumpf
Copy link
Member

Wumpf commented Feb 23, 2024

would be nice if arrow keys worked alongside WASD :)

@emilk
Copy link
Member Author

emilk commented Feb 26, 2024 •
edited
Loading

would be nice if arrow keys worked alongside WASD :)

I'd rather not move the goal post for this PR unnecessarily.

Sure it would be nice, but the arrow keys currently moves widget focus, so we would need some logic for when the arrow keys do what.

@Wumpf Wumpf self-requested a review February 26, 2024 09:27
@Wumpf
Copy link
Member

Wumpf commented Feb 26, 2024

image

default width for selection panel cuts the control off

@Wumpf
Copy link
Member

Wumpf commented Feb 26, 2024

Q/E for up/down is faster on orbital than on 1st person

Wumpf
Wumpf approved these changes Feb 26, 2024
View reviewed changes
crates/re_space_view_spatial/src/ui_3d.rs Outdated Show resolved Hide resolved
crates/re_space_view_spatial/src/eye.rs Outdated Show resolved Hide resolved
crates/re_space_view_spatial/src/eye.rs Outdated Show resolved Hide resolved
@Wumpf
Copy link
Member

Wumpf commented Feb 26, 2024

Q/E for up/down is faster on orbital than on 1st person

after having read the code I understand why and it kinda makes sense, we have to anchor the speed on different things 🤔

Great to finally have this. All good, the only thing bugging me a bit is the selection panel layout

@emilk emilk merged commit 81af851 into main Feb 26, 2024
40 checks passed
@emilk emilk deleted the emilk/first-person-camera branch February 26, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mode for first-person camera control
2 participants
@emilk @Wumpf